Unified: Resolve Self in static name binding - #22548
Merged
Merged
Conversation
hvitved
force-pushed
the
unified/implicit-self
branch
from
September 11, 2026 12:14
2dfc953 to
f86e1a4
Compare
self/SelfSelf in static name binding
hvitved
force-pushed
the
unified/implicit-self
branch
from
September 11, 2026 12:15
f86e1a4 to
2d10f98
Compare
hvitved
marked this pull request as ready for review
September 11, 2026 12:18
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Qualified type extensions still cannot resolve Self because their opaque names are not connected to type declarations.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
unified/ql/lib/codeql/unified/internal/StaticNameBinding.qll — Resolve Self in qualified type extensions |
What changed in this PR
Adds Swift Self resolution to unified static name binding.
Changes:
- Adds a language-plugin hook for static self names.
- Maps Swift
Selfto the enclosing type’s static namespace. - Adds class and inheritance tests.
| File | Description |
|---|---|
StaticNameBinding.qll |
Adds static-self namespace binding. |
NameBindingPlugin.qll |
Defines the plugin extension point. |
NameBindingPluginSwift.qll |
Configures Swift’s Self name. |
explicit-instance-field-access.swift |
Tests direct and inherited access. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
asgerf
reviewed
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DCA confirms a small improvement in number of resolved names.