util: fix inspect indentation of detached DataView - #66421
Open
Kjubikstronk wants to merge 1 commit into
Open
Kjubikstronk wants to merge 1 commit into
Kjubikstronk wants to merge 1 commit into
Conversation
formatExtraProperties() raised ctx.indentationLvl before reading the property. The getters of a detached DataView throw, so the level was never lowered again, and the DataView and everything inspected after it in the same call ended up indented too far. Read the value first. Signed-off-by: Miodrag Obradovic <mck097@gmail.com> Assisted-by: a closed-source coding agent
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
ljharb
approved these changes
Oct 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66421 +/- ##
=======================================
Coverage 90.37% 90.37%
=======================================
Files 792 792
Lines 275683 275686 +3
Branches 52854 52854
=======================================
+ Hits 249147 249159 +12
+ Misses 16947 16935 -12
- Partials 9589 9592 +3
🚀 New features to boost your workflow:
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
util.inspect()of aDataViewwhose buffer was detached comes out indented too far, and so does everything after it in the same output:The cause was
formatExtraProperties(): it raisedctx.indentationLvlbefore readingvalue[key]. On a detachedDataViewthebyteLengthandbyteOffsetgetters throw, so the-= 2never runs and 2 spaces leak per key, 4 in total.The bug came in with #60131, and the test added there asserted the leaked output.
Fix: read the value before indenting.
I built Node on Windows and tested it: the changed test fails without the fix and passes with it, as do 428 related tests.
I used Claude Code to find the bug and write the fix. I reviewed the diff and the changed assertion myself.
Refs: #60131